wonderking/continuity
2
0
Fork 0
Code Issues Pull requests 16 Projects 1 Releases Packages 1 Wiki Activity Actions

refactor: early return + itemids as span

Browse source
This commit is contained in:
Timothy Schenk 2023-11-25 14:21:55 +01:00
parent c4905b8cba
commit ec155ecab1
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Server/PacketHandlers/CharacterCreationHandler.cs
View file

@ -29,19 +29,23 @@ public class CharacterCreationHandler : IPacketHandler<CharacterCreationPacket>
public async Task HandleAsync(CharacterCreationPacket packet, TcpSession session) public async Task HandleAsync(CharacterCreationPacket packet, TcpSession session)
{ {
var authSession = session as AuthSession; if (session is not AuthSession authSession)
if (authSession is null)
{ {
return; return;
} }
var account = await _wonderkingContext.Accounts.FirstOrDefaultAsync(a => a.Id == authSession.AccountId); var account = await _wonderkingContext.Accounts.FirstOrDefaultAsync(a => a.Id == authSession.AccountId);
if (account is null)
{
return;
}
var firstJobConfig = SelectFirstJobConfig(packet.FirstJob); var firstJobConfig = SelectFirstJobConfig(packet.FirstJob);
var items = CreateDefaultItems(packet, firstJobConfig); var items = CreateDefaultItems(packet, firstJobConfig);
var toBeAddedCharacter = CreateDefaultCharacter(packet, account, items, firstJobConfig); var toBeAddedCharacter = CreateDefaultCharacter(packet, account, items, firstJobConfig);
account?.Characters.Add(toBeAddedCharacter); account.Characters.Add(toBeAddedCharacter);
await _wonderkingContext.SaveChangesAsync(); await _wonderkingContext.SaveChangesAsync();
var character = var character =
@ -92,7 +96,7 @@ public class CharacterCreationHandler : IPacketHandler<CharacterCreationPacket>
private static Character CreateDefaultCharacter(CharacterCreationPacket packet, Account account, private static Character CreateDefaultCharacter(CharacterCreationPacket packet, Account account,
InventoryItem[] items, JobSpecificMapping firstJobConfig) InventoryItem[] items, JobSpecificMapping firstJobConfig)
{ {
return new Character return new Character()
{ {
Account = account, Account = account,
MapId = 300, MapId = 300,
@ -154,8 +158,8 @@ public class CharacterCreationHandler : IPacketHandler<CharacterCreationPacket>
private static ushort[] GetItemIDsByInventoryTab(IEnumerable<Tuple<ushort, byte>> items) private static ushort[] GetItemIDsByInventoryTab(IEnumerable<Tuple<ushort, byte>> items)
{ {
var ids = new ushort[20]; Span<ushort> ids = stackalloc ushort[20];
ids.AsSpan().Clear(); ids.Clear();
foreach (var item in items) foreach (var item in items)
{ {
@ -167,6 +171,6 @@ public class CharacterCreationHandler : IPacketHandler<CharacterCreationPacket>
ids[item.Item2] = item.Item1; ids[item.Item2] = item.Item1;
} }
return ids; return ids.ToArray();
} }
} }